fix(clerk-js): Display alert on plan details error by panteliselef · Pull Request #6384 · clerk/javascript

panteliselef · 2025-07-24T10:25:36Z

Description

Checklist

pnpm test runs as expected.
pnpm build runs as expected.
(If applicable) JSDoc comments have been added or updated for any package exports
(If applicable) Documentation has been updated

Type of change

Summary by CodeRabbit

New Features
- Added a user-friendly alert that appears when there is an error loading plan details.
- Improved loading and error state layouts for a more consistent and visually centered experience.
Bug Fixes
- Enhanced error handling to provide clearer feedback when plan details fail to load.

changeset-bot · 2025-07-24T10:25:40Z

🦋 Changeset detected

Latest commit: 12a55c1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages

Name	Type
@clerk/clerk-js	Patch
@clerk/chrome-extension	Patch
@clerk/clerk-expo	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

vercel · 2025-07-24T10:25:41Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
clerk-js-sandbox	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jul 31, 2025 3:23pm

coderabbitai · 2025-07-24T10:28:57Z

📝 Walkthrough

Walkthrough

A new changeset file documents a patch update for the @clerk/clerk-js package, specifying that an alert will be shown for plan detail errors. In the PlanDetails.tsx file, the PlanDetailsInternal component is updated to improve error handling and loading UI. The SWR hook now manages an explicit error state and retains previous data during refetches. Two new internal components, BodyFiller and PlanDetailsError, are introduced to centralize layout and display error messages. The loading spinner and error alert are now consistently styled and centered using these components, and localization is applied to error messages.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 4f648b2 and 12a55c1.

📒 Files selected for processing (1)

packages/clerk-js/src/ui/components/Plans/PlanDetails.tsx (3 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

packages/clerk-js/src/ui/components/Plans/PlanDetails.tsx

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (5)

GitHub Check: semgrep-cloud-platform/scan
GitHub Check: Build Packages
GitHub Check: Formatting | Dedupe | Changeset
GitHub Check: semgrep/ci
GitHub Check: Analyze (javascript-typescript)

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

pkg-pr-new · 2025-07-24T10:30:13Z

Open in StackBlitz

@clerk/agent-toolkit

npm i https://pkg.pr.new/@clerk/agent-toolkit@6384

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@6384

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@6384

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@6384

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@6384

@clerk/dev-cli

npm i https://pkg.pr.new/@clerk/dev-cli@6384

@clerk/elements

npm i https://pkg.pr.new/@clerk/elements@6384

@clerk/clerk-expo

npm i https://pkg.pr.new/@clerk/clerk-expo@6384

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@6384

@clerk/express

npm i https://pkg.pr.new/@clerk/express@6384

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@6384

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@6384

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@6384

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@6384

@clerk/clerk-react

npm i https://pkg.pr.new/@clerk/clerk-react@6384

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@6384

@clerk/remix

npm i https://pkg.pr.new/@clerk/remix@6384

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@6384

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@6384

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@6384

@clerk/themes

npm i https://pkg.pr.new/@clerk/themes@6384

@clerk/types

npm i https://pkg.pr.new/@clerk/types@6384

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@6384

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@6384

commit: 12a55c1

alexcarpenter · 2025-07-24T13:29:54Z

packages/clerk-js/src/ui/components/Plans/PlanDetails.tsx


+const BodyFiller = ({ children }: { children: React.ReactNode }) => {
+  return (
+    <Drawer.Body>


Can we apply the padding to the body? Instead of needing the nested flex container without a descriptor?

possibly add a new variant prop to body padded? to create a consistent padding usage

the variant does not make much sense, I think it is better to use space.$4 everywhere. There are other places using this long with other settings. I will increase complexity to try to support both.

packages/clerk-js/src/ui/components/Plans/PlanDetails.tsx

alexcarpenter · 2025-07-24T13:30:44Z

packages/clerk-js/src/ui/components/Plans/PlanDetails.tsx

+  const { translateError } = useLocalizations();
+  return (
+    <BodyFiller>
+      <Alert


Can this be full width?

Do you want to force it ? If the error message is large enough it will occupy the necessary space.

Got it, just kind of feels weird at the size imo. Not a blocker though.

Here is a another error rendering full width already.

alexcarpenter · 2025-07-24T19:27:53Z

packages/clerk-js/src/ui/components/Plans/PlanDetails.tsx

+        display: 'flex',
+        flexDirection: 'column',
+        alignItems: 'center',
+        justifyContent: 'center',
+        flex: 1,
+        overflowY: 'auto',


body already handles a majority of these.

javascript/packages/clerk-js/src/ui/elements/Drawer.tsx

Lines 351 to 355 in 79b4f03

display: 'flex',

flexDirection: 'column',

flex: 1,

overflowY: 'auto',

overflowX: 'hidden',

Those are not inherited tho. If i removed the duplicate ones then this is the UI I end up with.

…etails

fix(clerk-js): Display alert on plan details error

01eb35a

panteliselef requested review from a team and aeliox July 24, 2025 10:25

panteliselef self-assigned this Jul 24, 2025

clerk-cookie added the clerk-js label Jul 24, 2025

vercel bot deployed to Preview July 24, 2025 10:26 View deployment

fix(clerk-js): Display alert on plan details error

9edfad5

vercel bot deployed to Preview July 24, 2025 10:32 View deployment

mauricioabreu approved these changes Jul 24, 2025

View reviewed changes

alexcarpenter reviewed Jul 24, 2025

View reviewed changes

address feedback

4f648b2

vercel bot deployed to Preview July 24, 2025 15:46 View deployment

alexcarpenter reviewed Jul 24, 2025

View reviewed changes

aeliox approved these changes Jul 25, 2025

View reviewed changes

Merge branch 'main' into elef/com-1068-handle-plan-not-found-in-pland…

12a55c1

…etails

vercel bot deployed to Preview July 31, 2025 15:23 View deployment

panteliselef enabled auto-merge (squash) July 31, 2025 15:29

panteliselef merged commit 813e738 into main Jul 31, 2025
36 checks passed

panteliselef deleted the elef/com-1068-handle-plan-not-found-in-plandetails branch July 31, 2025 15:32

clerk-cookie mentioned this pull request Jul 31, 2025

ci(repo): Version packages #6429

Merged

	display: 'flex',
	flexDirection: 'column',
	flex: 1,
	overflowY: 'auto',
	overflowX: 'hidden',

Comments

Conversation

panteliselef commented Jul 24, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Checklist

Type of change

Summary by CodeRabbit

Uh oh!

changeset-bot bot commented Jul 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

vercel bot commented Jul 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai bot commented Jul 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Estimated code review effort

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

pkg-pr-new bot commented Jul 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

alexcarpenter Jul 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

alexcarpenter Jul 24, 2025

Choose a reason for hiding this comment

Uh oh!

panteliselef Jul 24, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

alexcarpenter Jul 24, 2025

Choose a reason for hiding this comment

Uh oh!

panteliselef Jul 24, 2025

Choose a reason for hiding this comment

Uh oh!

alexcarpenter Jul 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

alexcarpenter Jul 24, 2025

Choose a reason for hiding this comment

Uh oh!

panteliselef Jul 31, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

panteliselef commented Jul 24, 2025 •

edited by coderabbitai bot

Loading

changeset-bot bot commented Jul 24, 2025 •

edited

Loading

vercel bot commented Jul 24, 2025 •

edited

Loading

coderabbitai bot commented Jul 24, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

pkg-pr-new bot commented Jul 24, 2025 •

edited

Loading

alexcarpenter Jul 24, 2025 •

edited

Loading

alexcarpenter Jul 24, 2025 •

edited

Loading